Update testdriver's set_permission methods to accept optional embeddedOrigin#55452
Merged
jcscottiii merged 7 commits intoweb-platform-tests:masterfrom Oct 20, 2025
Merged
Conversation
wpt-pr-bot
added
infra
testdriver.js
wptrunner
wpt-pr-bot
requested review from
DanielRyanSmith,
foolip,
jgraham and
jonathan-j-lee
sadym-chromium
approved these changes
Oct 20, 2025
foolip
approved these changes
Oct 20, 2025
Contributor
|
Synced with @jalonthomas offline about the failing infrastructure test (/infrastructure/reftest/testdriver-iframe.sub.html). He's unable to repro this locally. Likely unrelated. Will force merge after one typical re-run. |
Contributor
|
Force merging. |
mertcanaltin
pushed a commit
to mertcanaltin/wpt
that referenced
this pull request
Oct 26, 2025
…edOrigin` (web-platform-tests#55452) * Add embedded_origin to testdriver * Add param to WebDriverBidiPermissionsProtocolPart * Finish updating to embeddedOrigin * Add param types and return types * Return awaitable instead of None * Use Any return type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align with addition: w3c/permissions#469
WPT: #55137
chromium-bidi change: GoogleChromeLabs/chromium-bidi#3799